refactor(atomic): migrate atomic-insight-search-box to Lit by Copilot · Pull Request #6881 · coveo/ui-kit

Copilot · 2026-01-02T13:36:27Z

✅ Checklist

https://coveord.atlassian.net/browse/KIT-4933

…ncil to Lit Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>

…h-box Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>

packages/atomic/src/components/common/suggestions/query-suggestions.spec.ts

...es/atomic/src/components/insight/atomic-insight-search-box/atomic-insight-search-box.spec.ts

SimonMilord

👍

erocheleau

I know this was already merged, but I do have some comments and questions as there are changes between the stencil version and this one.

erocheleau · 2026-01-14T18:41:44Z

packages/atomic/src/components/common/suggestions/query-suggestions.spec.ts

    expect(icon).not.toBeInTheDocument();
  });

+  it('should render the icon when alwaysShowIcon is true even if hasMultipleKindOfSuggestions is false', async () => {


Not sure I'm clear on the relation between hasMultipleKindOfSuggestions and the option alwaysShowIcon ?

alwaysShowIcon is an override that forces the icon to display even when hasMultipleKindOfSuggestions is false (which normally hides icons when there's only one suggestion type).

erocheleau · 2026-01-14T18:42:20Z

packages/atomic/src/components/common/suggestions/query-suggestions.ts

+   * When true, the icon will always be displayed regardless of hasMultipleKindOfSuggestions.
+   * Used by the insight search box where icons should always be visible.
+   */
+  alwaysShowIcon?: boolean;


What's that exactly?
The icon next to the query suggestions?

yes exactly. For search we dont always show it

erocheleau · 2026-01-14T18:56:26Z

...es/atomic/src/components/insight/atomic-insight-search-box/atomic-insight-search-box.spec.ts

+      const {textArea} = await renderComponent();
+      await userEvent.type(textArea, 'test');
+      expect(dispatchSpy).toHaveBeenCalledWith(
+        expect.objectContaining({type: 'fetchQuerySuggestions'})


Can we also validate here that it was called with the right query value?

yes we could do that.

...es/atomic/src/components/insight/atomic-insight-search-box/atomic-insight-search-box.spec.ts

packages/atomic/src/components/insight/atomic-insight-search-box/atomic-insight-search-box.ts

erocheleau · 2026-01-14T21:05:10Z

packages/atomic/src/components/insight/atomic-insight-search-box/atomic-insight-search-box.ts

+        hasMultipleKindOfSuggestions: false,
+        alwaysShowIcon: this.searchBoxState.suggestions.length > 1,


I'm still unclear on the relation between these two attributes that seem to decide if we're supposed to render an icon or not?

When suggestions are there, we want to always show an icon for insight. Search has logic for this, insight just always shows an icon so I added this prop to make it work.

erocheleau · 2026-01-14T21:05:44Z

packages/atomic/src/components/insight/atomic-insight-search-box/atomic-insight-search-box.ts

+    getRef: () => HTMLElement | undefined
+  ): TemplateResult | typeof nothing {
+    if (!elements.length) {
+      return nothing;


Again with the nothing instead of null?
Is it expected that the lit nothing is not the same type as TemplateResult ?

Yes it is expected and quite annoying imo, we had to add it in some internal types.

Copilot AI self-assigned this Jan 2, 2026

Initial plan

abd9f9b

Copilot AI assigned alexprudhomme Jan 2, 2026

Copilot started work on behalf of alexprudhomme January 2, 2026 13:36 View session

Copilot AI and others added 2 commits January 2, 2026 13:52

Step 1 complete: Migrate atomic-insight-search-box component from Ste…

687bcef

…ncil to Lit Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>

Step 2 progress: Add unit tests and fixtures for atomic-insight-searc…

bd740ff

…h-box Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Migrate the atomic-insight-search-box component to Lit~~ feat(atomic): migrate atomic-insight-search-box to Lit Jan 2, 2026

Copilot AI requested a review from alexprudhomme January 2, 2026 14:01

Copilot finished work on behalf of alexprudhomme January 2, 2026 14:01

alexprudhomme added new-lit-component chromatic Opt-in w/ Chromatic labels Jan 2, 2026

alexprudhomme changed the title ~~feat(atomic): migrate atomic-insight-search-box to Lit~~ refactor(atomic): migrate atomic-insight-search-box to Lit Jan 2, 2026

alexprudhomme added 2 commits January 13, 2026 08:55

Merge branch 'main' into copilot/migrate-atomic-insight-search-box

3390de1

merge

9aabcd2

alexprudhomme temporarily deployed to PR Artifacts January 13, 2026 14:11 — with GitHub Actions Inactive

alexprudhomme temporarily deployed to Prerelease (CDN) January 13, 2026 14:17 — with GitHub Actions Inactive

alexprudhomme temporarily deployed to PR Artifacts January 13, 2026 14:25 — with GitHub Actions Inactive

alexprudhomme temporarily deployed to PR Artifacts January 13, 2026 14:39 — with GitHub Actions Inactive

alexprudhomme had a problem deploying to PR Artifacts January 13, 2026 14:39 — with GitHub Actions Failure

done

1eddff3

alexprudhomme force-pushed the copilot/migrate-atomic-insight-search-box branch from 98fbe02 to 1eddff3 Compare January 13, 2026 14:40

alexprudhomme temporarily deployed to PR Artifacts January 13, 2026 14:40 — with GitHub Actions Inactive

developer-experience-bot bot and others added 3 commits January 13, 2026 14:45

Add generated files

235bef5

done

fd43bac

remove s

27f5d36

alexprudhomme requested a review from fbeaudoincoveo January 13, 2026 15:54

alexprudhomme temporarily deployed to PR Artifacts January 13, 2026 15:56 — with GitHub Actions Inactive

alexprudhomme temporarily deployed to Prerelease (CDN) January 13, 2026 16:02 — with GitHub Actions Inactive

alexprudhomme temporarily deployed to PR Artifacts January 13, 2026 16:10 — with GitHub Actions Inactive

Update insight-panel.cypress.ts

c937644

alexprudhomme requested a review from a team as a code owner January 13, 2026 17:17

alexprudhomme temporarily deployed to PR Artifacts January 13, 2026 17:18 — with GitHub Actions Inactive

alexprudhomme temporarily deployed to Prerelease (CDN) January 13, 2026 17:24 — with GitHub Actions Inactive

alexprudhomme temporarily deployed to PR Artifacts January 13, 2026 17:31 — with GitHub Actions Inactive

louis-bompart approved these changes Jan 13, 2026

View reviewed changes

SimonMilord reviewed Jan 14, 2026

View reviewed changes

packages/atomic/src/components/common/suggestions/query-suggestions.spec.ts Show resolved Hide resolved

SimonMilord reviewed Jan 14, 2026

View reviewed changes

...es/atomic/src/components/insight/atomic-insight-search-box/atomic-insight-search-box.spec.ts Show resolved Hide resolved

SimonMilord approved these changes Jan 14, 2026

View reviewed changes

Merge branch 'main' into copilot/migrate-atomic-insight-search-box

6c8ea82

alexprudhomme temporarily deployed to PR Artifacts January 14, 2026 20:16 — with GitHub Actions Inactive

alexprudhomme enabled auto-merge January 14, 2026 20:16

alexprudhomme temporarily deployed to Prerelease (CDN) January 14, 2026 20:22 — with GitHub Actions Inactive

alexprudhomme temporarily deployed to PR Artifacts January 14, 2026 20:29 — with GitHub Actions Inactive

alexprudhomme added this pull request to the merge queue Jan 14, 2026

Merged via the queue into main with commit ca2020a Jan 14, 2026
182 of 185 checks passed

alexprudhomme deleted the copilot/migrate-atomic-insight-search-box branch January 14, 2026 20:49

alexprudhomme temporarily deployed to PR Artifacts January 14, 2026 20:49 — with GitHub Actions Inactive

erocheleau reviewed Jan 14, 2026

View reviewed changes

		hasMultipleKindOfSuggestions: false,
		alwaysShowIcon: this.searchBoxState.suggestions.length > 1,

Comments

Conversation

Copilot AI commented Jan 2, 2026 • edited by alexprudhomme Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Checklist

Uh oh!

Uh oh!

Uh oh!

SimonMilord left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erocheleau left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Jan 2, 2026 •

edited by alexprudhomme

Loading